Add support for canonical k8s #357
Open
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
|
@Thanhphan1147 what is the status here, please? |
arturo-seijas
approved these changes
Feb 10, 2025
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
| if: inputs.use-canonical-k8s && inputs.provider == 'k8s' | ||
| id: canonical-k8s | ||
| run: | | ||
| sudo snap install k8s --channel=${{ inputs.channel }} --classic |
There was a problem hiding this comment.
Maybe use another input variable for the channel? The default is latest/stable, and that does not exists for that snap.
There was a problem hiding this comment.
That's not the best but I don't know if it's worth adding another option for this. I believe it might lead to confusion
| echo "kubeconfig=$(sudo k8s config | base64 -w 0)" >> $GITHUB_OUTPUT | ||
|
|
||
| IPADDR=$(ip -4 -j route get 2.2.2.2 | jq -r '.[] | .prefsrc') | ||
| LB_FIRST_ADDR="$(echo "${IPADDR}" | awk -F'.' '{print $1,$2,$3,100}' OFS='.')" |
There was a problem hiding this comment.
I do not know much about this, but you will this work out of the box? You are in a subnet with other machines that may reply to arp requests for some of those ips.
Signed-off-by: Phan Trung Thanh <trung.thanh.phan@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an input
use-canonical-k8sto theintegration-testworkflow to allow deploying juju applications on canonical-k8s.For now, this parameter must be used in conjuction with
provider: k8sso thataction-operatorbootstraps canonical-k8s as a generic cluster when creating the juju controller.action-operatorwill add support for canonical-k8s in the future. Until then, this will be used as a workaround since it's needed to test workflows running on canonical-k8s.Checklist
urgent,trivial,complex)